gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

ci: codedev token

Open zirain opened this issue 1 year ago • 4 comments

fix: https://github.com/envoyproxy/gateway/pull/2558

doc: https://docs.codecov.com/docs/adding-the-codecov-token#github-actions

zirain avatar Feb 06 '24 10:02 zirain

@phlax @Xunzhuo need token for codedev, can you help to set the secret?

zirain avatar Feb 06 '24 10:02 zirain

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a5125bf) 63.41% compared to head (82638c2) 63.43%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2568      +/-   ##
==========================================
+ Coverage   63.41%   63.43%   +0.02%     
==========================================
  Files         119      119              
  Lines       19227    15540    -3687     
==========================================
- Hits        12193     9858    -2335     
+ Misses       6222     4870    -1352     
  Partials      812      812

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 10:02 codecov[bot]

Will update it tomorrow

Xunzhuo avatar Feb 06 '24 12:02 Xunzhuo

Will update it tomorrow

not sure why it's passed now.

zirain avatar Feb 06 '24 12:02 zirain

Should we close this ?

Xunzhuo avatar Mar 01 '24 06:03 Xunzhuo

Should we close this ?

yeah, I crosschecked and we are not adding a TOKEN to our repo or org secrets, so not sure what's happening here

arkodg avatar Mar 02 '24 02:03 arkodg

/close this for now, reopen it if needed later

Xunzhuo avatar Mar 02 '24 02:03 Xunzhuo