gateway

gateway copied to clipboard

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #https://github.com/envoyproxy/gateway/issues/2033

Nov 28 '23 12:11 TasdidurRahman

BTW, did upstream has a test for this? if not, can you add a new e2e test?

Dec 01 '23 13:12 zirain

BTW, did upstream has a test for this? if not, can you add a new e2e test?

ok, will add e2e test for upstream tls

Dec 01 '23 15:12 TasdidurRahman

Thanks for working on this! This PR is in a good shape, but there're a few things I'd like to improve:

• Error handling
• Policy status update
• unit and e2e tests

thanks @zhaohuabing for the review, I am working on it

Dec 05 '23 05:12 TasdidurRahman

hey @TasdidurRahman, can you address the comments ?

Jan 04 '24 00:01 arkodg

hey @TasdidurRahman, can you address the comments ?

hello @arkodg , I have checked the comments and working accordingly. thanks!

Jan 04 '24 09:01 TasdidurRahman

hey @TasdidurRahman any update on this PR ? (this feature unblocks many users from adopting envoy gateway)

Jan 17 '24 19:01 arkodg

hey @TasdidurRahman any update on this PR ? (this feature unblocks many users from adopting envoy gateway)

the status update is working fine. adding the e2e test. will be done by next week @arkodg

Jan 18 '24 13:01 TasdidurRahman

hey @TasdidurRahman ive started working on downstream mTLS https://github.com/envoyproxy/gateway/pull/2490 which is very similar to this PR, will try and wrap this up by this week, so this PR can reuse the same components for upstream tls

Jan 23 '24 22:01 arkodg

Sorry for the delay @TasdidurRahman , #2490 has merged, recommend using those helper xds methods for this PR as well, tia

Feb 14 '24 01:02 arkodg

Sorry for the delay @TasdidurRahman , #2490 has merged, recommend using those helper xds methods for this PR as well, tia

np, will do it asap

Feb 14 '24 05:02 TasdidurRahman

Codecov Report

Attention: Patch coverage is 50.43478% with 171 lines in your changes are missing coverage. Please review.

Project coverage is 63.42%. Comparing base (ca572b8) to head (a3b39f2).

@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
- Coverage   63.63%   63.42%   -0.21%     
==========================================
  Files         123      125       +2     
  Lines       20189    20532     +343     
==========================================
+ Hits        12847    13023     +176     
- Misses       6519     6671     +152     
- Partials      823      838      +15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Feb 14 '24 21:02 codecov[bot]

@TasdidurRahman are you still working on this, we're close to release, I'd like see this happen in next release. if not, I can pick this up.

Feb 27 '24 08:02 zirain

working on it

Feb 28 '24 04:02 TasdidurRahman

please add e2e and user doc if you can.

Mar 01 '24 05:03 zirain

Hey @TasdidurRahman can you rebase ?

Mar 01 '24 05:03 arkodg

Hey @TasdidurRahman can you rebase ?

hi @arkodg , I have rebased

Mar 01 '24 09:03 TasdidurRahman

@TasdidurRahman can you fix the lint errors, running make lint locally should highlight the errors

Mar 02 '24 02:03 arkodg

/retest

Mar 02 '24 09:03 zirain

/retest

Mar 03 '24 10:03 Xunzhuo

@TasdidurRahman all the conformance tests are failing, can you ptal

Mar 03 '24 23:03 arkodg

@TasdidurRahman all the conformance tests are failing, can you ptal

hi @arkodg , can you rerun the test? ig it was rbac issue

Mar 04 '24 06:03 TasdidurRahman

@TasdidurRahman all the conformance tests are failing, can you ptal

hi @arkodg , can you rerun the test? ig it was rbac issue

you can retrigger ci /retest

Mar 04 '24 13:03 zirain

/retest

Mar 04 '24 13:03 zirain