AbpDevTools icon indicating copy to clipboard operation
AbpDevTools copied to clipboard

feat(): angular support

Open nebula2 opened this issue 1 year ago • 5 comments

Not an angular expert - but maybe this does the job for now. If not, it hopefully leads to some starting point.

Tested build and run - both work. Did not test with a configuration though - but should also work.

You must add angular to your run config In order to get this running (see RunConfiguration.cs).

image

Maybe Closes #2

nebula2 avatar Mar 03 '24 10:03 nebula2

Thanks for your contribution, it seems perfect 👌

I'll try and merge asap

enisn avatar Mar 05 '24 06:03 enisn

You seem like first-time contributor still, I think your email in git config doesn't match your github account email, probably you won't be listed as contributor by GitHub in the repository

image

Just an information, if you dont care about it, that's ok to me

enisn avatar Mar 05 '24 06:03 enisn

You seem like first-time contributor still, I think your email git config doesn't match your github account email, probably you won't be listed as contributor by GitHub in the repository

image

Just an information, if you dont care about it, that's ok to me

oops. thanks for telling me that. must have messed this up :-|

nebula2 avatar Mar 05 '24 08:03 nebula2

Everything seems good but instead of using RunningCsProjItem, we can create another class for angular projects such as ``RunningPackageJsonItemorRunningAngularItem` etc.

Implementing all the logic in a single class increases maintaining cost, I'll implement add some other platform support here too (maui, mauiblazor, react native etc.) and they should be separated classes to manage easily

makes sense. I'll try to change that over the weekend :)

nebula2 avatar Mar 06 '24 17:03 nebula2

Everything seems good but instead of using RunningCsProjItem, we can create another class for angular projects such as ``RunningPackageJsonItemorRunningAngularItem` etc. Implementing all the logic in a single class increases maintaining cost, I'll implement add some other platform support here too (maui, mauiblazor, react native etc.) and they should be separated classes to manage easily

makes sense. I'll try to change that over the weekend :)

sry I am too busy at the moment with my business. I do not know when I find the time to implement this properly. I'll finish it when I find a free spot - if it hasn't been done by someone else in the meantime

nebula2 avatar Mar 31 '24 16:03 nebula2