emscripten icon indicating copy to clipboard operation
emscripten copied to clipboard

[WebIDL] Generate correct code when a pointer is returned from an interface method

Open agnickolov opened this issue 1 year ago • 1 comments

This fixes the problem reported under issue https://github.com/emscripten-core/emscripten/issues/14745. The previous two PRs were never completed: https://github.com/emscripten-core/emscripten/pull/15651 https://github.com/emscripten-core/emscripten/pull/14795

Those developers are no longer involved with the project this issue is blocking and it fell to me to get it through to completion. I cleaned up the test code a bit from the earlier PRs as well. Please look at the previous PRs for details.

agnickolov avatar May 14 '24 19:05 agnickolov

I'm concerned that I'm getting test failures with the fixed code.

At least one of the failures seems to be due to a configuration issue. The following unexpected line appears in the test output: +Warning: Enlarging memory arrays, this is not fast! 16908288,25296896 I'm not sure what should be done about it, however.

Another test appears to be failing due to unmet memory management expectations. Again I have no clue what to do about that. The failures are likely caused by the newly added test allocating new objects and thus changing the memory layout.

I ended up rearranging the WebIDL test code. Hopefully that fixes the test issues. The heap checks were getting thrown off, so I moved the new test before those.

agnickolov avatar May 14 '24 21:05 agnickolov

All tests appear to be passing, but an archive check seems to have stalled...

agnickolov avatar May 15 '24 15:05 agnickolov