emscripten icon indicating copy to clipboard operation
emscripten copied to clipboard

Published 20 hours ago • verified publisher icon emscripten-core

Rename WGPUDeviceLostReason_Undefined to Unknown

Open hocheung-chromium opened this issue 1 year ago • 2 comments

Please check https://issues.chromium.org/issues/42241081 for more information and progress.

webgpu-headers PR: https://github.com/webgpu-native/webgpu-headers/pull/288.

@kainino0x @austinEng

hocheung-chromium avatar May 09 '24 06:05 hocheung-chromium

I believe for this PR as well, unknown should be value 0x1, and destroyed should be value 0x2

austinEng avatar May 10 '24 16:05 austinEng

I believe for this PR as well, unknown should be value 0x1, and destroyed should be value 0x2

I have redefined the values for Unknown and Destoryed

@austinEng

hocheung-chromium avatar May 11 '24 12:05 hocheung-chromium

looks good to me, but I don't have review permissions

austinEng avatar May 15 '24 14:05 austinEng

Hello Kai Ninomiya, could you please take a moment to review this PR? Thanks.

@kainino0x

hocheung-chromium avatar May 15 '24 14:05 hocheung-chromium