ember-no-implicit-this-codemod icon indicating copy to clipboard operation
ember-no-implicit-this-codemod copied to clipboard

Published 20 hours ago • verified publisher icon ember-codemods

Support for pods?

Open scottkidder opened this issue 6 years ago • 5 comments

Is it possible for this codemod to support pods layout?

scottkidder avatar Oct 23 '19 15:10 scottkidder

Does it not support pods? I haven't tested

NullVoxPopuli avatar Oct 23 '19 15:10 NullVoxPopuli

I've only tried our app so far. I haven't investigated but it appears to not properly associate the files with the telemetry output causing every file to be skipped.

Here is an example line from codemods.log:

2019-10-23T15:28:39.135Z [warn] [app/components/account-listing/template.hbs]: SKIPPED Could not find runtime data NO_RUNTIME_DATA

scottkidder avatar Oct 23 '19 15:10 scottkidder

Thanks! That's helpful! Can you open an issue on the codemod telemetry repo as well? The helpers for accessing info by path live in that repo

NullVoxPopuli avatar Oct 23 '19 15:10 NullVoxPopuli

Hi in this issue in angle brackets codemod https://github.com/ember-codemods/ember-angle-brackets-codemod/issues/217 running with --no-telemetry do the trick for me in my pods projects. Anyone knows if you can use that here?

pabloascarza avatar May 13 '21 14:05 pabloascarza

For those who land on this issue, I wrote a codemod to un-pod Ember projects. Maybe try it out as a prerequisite to running ember-no-implicit-this-codemod?

ijlee2 avatar Jul 22 '22 17:07 ijlee2