ember-native-class-codemod icon indicating copy to clipboard operation
ember-native-class-codemod copied to clipboard

Some files not transformed and not mentioned in codemod.log

Open kategengler opened this issue 6 years ago • 3 comments

I have several/many files that were not modified and are not mentioned in codemod.log, one example file:

// app/models/purchase.js

import DS from 'ember-data';
import attr from 'ember-data/attr';

export default DS.Model.extend({
  action: attr('string'),
  currency: attr('string'), 
  quantity: attr('number'),
  valueUsd: attr('number'),
});

kategengler avatar Jun 23 '19 20:06 kategengler

Tried this on EmberObserver, https://github.com/emberobserver/client/tree/es6-class-codemod

Committed codemods.log as well.

This can be seen with app/models/github-stats.js -- it does not appear in codemods.log and was not transformed.

kategengler avatar Jun 23 '19 20:06 kategengler

We state in the README that we avoid migrating DS.Model, DS.Adapter, etc, are all of the untransformed file types ember-data object types?

rwjblue avatar Jun 23 '19 23:06 rwjblue

Yes, they are, but other ember-data objects were transformed.

kategengler avatar Jul 26 '19 23:07 kategengler