ember-cli-mocha icon indicating copy to clipboard operation
ember-cli-mocha copied to clipboard

HTML Reporter never updates it's progress, and never sets the "finished" class on the #mocha div

Open fushi opened this issue 8 years ago • 10 comments

We use this in our CI to tell when the tests finish. Is there a workaround?

fushi avatar Dec 01 '16 19:12 fushi

@fushi can you elaborate? I'm not quite sure what you're talking about

Turbo87 avatar Dec 01 '16 19:12 Turbo87

screen shot 2016-12-01 at 12 57 31 pm

fushi avatar Dec 01 '16 20:12 fushi

The tests are done in that picture, but the completed percent shows as 0%, and the Mocha window is still yellow, because

doesn't have class="finished"

fushi avatar Dec 01 '16 20:12 fushi

@fushi this looks like you are not using the default reporter. can you provide a repository to reproduce your issues?

Turbo87 avatar Dec 01 '16 21:12 Turbo87

That is the default reporter, as far as I can tell. I've done nothing but ember install ember-cli-mocha and rm -rf node_modules && npm install.

Then I run ember serve and browse to /tests/.

Can you show a screenshot of what you're expecting?

fushi avatar Dec 01 '16 21:12 fushi

@fushi I'm pretty sure that this has worked at some point in the past, but apparently it no longer does. I've been able to reproduce this in a fresh new app.

Turbo87 avatar Dec 02 '16 09:12 Turbo87

We use this in our CI to tell when the tests finish.

why don't you use ember test instead?

Turbo87 avatar Dec 02 '16 09:12 Turbo87

We're moving from ember (non-cli) to ember-cli, and the current method of build/test for CI is the following:

Build on build server Deploy to dev environment Run selenium from build server using a grid of workers, against dev environment url with &grep= GET arguments.

I'm not opposed to changing that, I just don't yet know how we'd go about parallelizing test execution in the new way of doing things.

The main issue I'm having is that I need the test results back on the build server, but I'm not sure I can run anything graphical there (and phantomjs doesn't seem to run any of the integration tests)

fushi avatar Dec 03 '16 00:12 fushi

This was fixed in https://github.com/mochajs/mocha/pull/2299 - but it's only in mocha 3.x

adamjmcgrath avatar Jan 25 '17 10:01 adamjmcgrath

good to know, thanks @adamjmcgrath! looks like we have one more reason to migrate to Mocha 3.

Turbo87 avatar Jan 25 '17 10:01 Turbo87