Maksim Ivanov
Maksim Ivanov
> @emaxx-google please try setting `USE_BAZEL_VERSION=fc930be6e7823264c382a39a9cc1dbd19f43b863` Hmm, I'm afraid the build via this version hung: it's been running on one of the bots for more than 4 hours without visible...
Sure, I'll look into both ideas: getting the stack trace on the first commit (someone on the team might have necessary permissions) and trying the second commit. BTW, given that...
> @emaxx-google Can you try your CQ with version `9cbbd7d2c9b783f80a816b188ac3a7a7025bdd1f`? It's essentially #22215 rebased and whereas I'm not in love with it for the same reasons @Wyverald isn't, it would...
I've guarded some code in `in-popup-main-script.js` with checks because when the window is opened via `createWindow()` there's no `popup_id` passed and there's no need in one.
One of the tests failed - seems like a real problem with composite devices. Looking into it.
> One of the tests failed - seems like a real problem with composite devices. Looking into it. Fixed now.
I realized I need to add `await` when calling `assertRejects` in tests, so that we don't leave the test body before the assertion has been checked.