openid2go icon indicating copy to clipboard operation
openid2go copied to clipboard

A bunch of fixes

Open lonelycode opened this issue 9 years ago • 3 comments

I don't expect this to be merged, but some of these commits might help... we've been using this a lot and discovered that it is not concurrency safe and so have added some mutexes.

Also worth noting is there is a bug which caused the JWK to always be refreshed which is now fixed.

Because type assertions are used quite liberally there's a lot of places panics can occur when a map read doesn't turn out as expected - have tried to address the one that's been causing the most headaches.

Oh, and this uses JWT-go v3

:-)

lonelycode avatar Aug 17 '16 22:08 lonelycode

Thanks for sending this in Martin. I have been meaning to fix some of these issues (jwt v3, concurrency, ...) and haven't got around that. I am glad somebody did :). I will review all the changes and merge them. Will let you know if I have any question on gitter, stay tuned. Thanks for using and contributing back.

emanoelxavier avatar Aug 17 '16 22:08 emanoelxavier

I will be merging/tackling these changes piece by piece. I have just handled the changes needed for jwt 3.0.

emanoelxavier avatar Sep 11 '16 20:09 emanoelxavier

Hmmm, for the life of me I cannot remember :-/

lonelycode avatar Nov 28 '16 07:11 lonelycode