lsp-ui icon indicating copy to clipboard operation
lsp-ui copied to clipboard

lsp-ui-sideline pop message break line on emacs 29.0.60

Open liuchong opened this issue 2 years ago • 11 comments

The pop out alert message of lsp-ui-sideline added a line break, when move the cursor on and off the error code, the window will change. It's annoying, just disable lsp-ui-sideline-mode is ok, maybe. 🔥

Normal: image

Normal in small window: image

Broken in wide window: image

Disabled: image

liuchong avatar Mar 23 '23 04:03 liuchong

Is this unsolved? #96

Flinner avatar Mar 31 '23 11:03 Flinner

Is this unsolved? #96

I noticed that #96 is an old issue and seems was fixed, not sure if it is same problem as what I found, or maybe new version of emacs breaks it again? @Flinner The difference of my issue and #96 is that is the real message breaks line, but this is not real message but only a small word references does it.

liuchong avatar Apr 04 '23 11:04 liuchong

I'm experiencing this too with Emacs 29.0.91. It makes writing code very annoying, especially with Dart, since Dart has labels at the end of every nested structure, and while typing, lines are constantly jumping as sideline actions appear and disappear.

Screenshot_20230528_224945

ivan-avalos avatar May 29 '23 04:05 ivan-avalos

I don't know if this will work, but you can try sideline and sideline-lsp. Pretty much the improved version of lsp-ui-sideline.

jcs090218 avatar May 29 '23 07:05 jcs090218

There seems has similar problem in sideline-lsp, please check the below images:

Normal: image Sideline enabled: image

liuchong avatar May 29 '23 10:05 liuchong

I think the prompt message on the right should not effect the display of source codes on the left.

liuchong avatar May 29 '23 10:05 liuchong

Thanks for testing it out! I will investigate the bug. ;)

jcs090218 avatar May 29 '23 20:05 jcs090218

@jcs090218 hi, did you fixed it? 👀

liuchong avatar Jul 14 '23 03:07 liuchong

I have taken a closer look at the issue. It seems like it's a conflict with other overlays. 🤔

For sideline-lsp, you can try:

(setq sideline-backends-right-skip-current-line t)

There isn't a good solution yet since there isn't a good way to calculate all the overlays in the buffer/window. 😓

jcs090218 avatar Jul 14 '23 06:07 jcs090218

Maybe create another layer on top of the editing buffer when popping out the message? @jcs090218 👀

liuchong avatar Jul 14 '23 09:07 liuchong

Maybe create another layer on top of the editing buffer when popping out the message?

No, we already have lsp-ui-doc that does that. I don't think that will solve the issue, but making it customizable might be one solution (use different frontend). 🤔

jcs090218 avatar Jul 14 '23 20:07 jcs090218