evil icon indicating copy to clipboard operation
evil copied to clipboard

Fix: Should not (evil-set-jump previous-pos) jump after evil-jump-forward

Open roxma opened this issue 2 years ago • 2 comments

Steps to reproduce the issue:

  • Create files a b c with the following content:
        $ head a b c
        ==> a <==
        b
    
        I'm A
        ==> b <==
        c
    
        I'm B
        ==> c <==
        I'm C
  • Run emancs a to open bufer a
  • Press gf to jump to bufer b
  • Press gf to jump to bufer c
  • Press C-o to jump back to bufer b
  • Press C-o to jump back to bufer a
  • Press C-i to jump foward to bufer b
  • Press C-i to jump foward to bufer c, but the window stays on buffer b unexpectedly.

roxma avatar Mar 26 '23 15:03 roxma

@tomdl89 @axelf4 Hi, could you please comment on this pull request?

roxma avatar Jun 09 '23 15:06 roxma

@roxma thanks for the PR. As mentioned in the comment, I don't think you need to revert the renaming. Can you add tests for this? I've noticed there are tests in the deftest evil-test-jump, namely in the ert-info Jump across files, which you may be able to add to. Could you take a look? Thanks.

tomdl89 avatar Jun 10 '23 14:06 tomdl89

Has there been any progress? I also have this problem. Whenever I jump back repeatedly, I can only jump forwards once.

dschrempf avatar Jul 11 '24 19:07 dschrempf

@dschrempf apologies for the delay. Now fixed in master. Please let me know if you observe otherwise.

tomdl89 avatar Jul 12 '24 22:07 tomdl89

Wow, that was fast, thanks a lot!

dschrempf avatar Jul 13 '24 14:07 dschrempf

@tomdl89 Thank you for adding the tests.

roxma avatar Jul 23 '24 07:07 roxma

I can also confirm that this is working! Thanks!

dschrempf avatar Jul 23 '24 12:07 dschrempf