axon icon indicating copy to clipboard operation
axon copied to clipboard

Text Classification LSTM Livebook & Example Integration

Open fantypants opened this issue 3 years ago • 2 comments

Hello,

This is the initial implementation of the LSTM NER Text Classification. I've worked on the live-book & example for the model.

fantypants avatar Jul 23 '22 15:07 fantypants

@seanmor5 I've finished the changes and pushed to my main branch, how do I update the PR with the additions?

Edit: Just seen them come through, please let me know if there is anything more I can make better. If this is all good, i'll update the LiveBook example with the new additions

fantypants avatar Jul 31 '22 11:07 fantypants

filename has one too many s's, and directory has one too few i's

examples/classifcation/text_classsification.exs -> examples/classification/text_classification.exs

jdewar avatar Aug 24 '22 15:08 jdewar

@fantypants Hey! Just checking up on the status of this PR? Do you need help or another review?

seanmor5 avatar Oct 27 '22 22:10 seanmor5

@fantypants Hey! Just checking up on the status of this PR? Do you need help or another review?

Hey @seanmor5, Apologies for the delay, I do believe it would be good for a review soon; however, I'll take a look over it tomorrow and fix another highlighted issue with the filename. I also have to go through the changes of late to make sure it's all still compatible. I'll give you a shout on here when it's ready (1-2 Days).

fantypants avatar Oct 27 '22 23:10 fantypants