riot-android icon indicating copy to clipboard operation
riot-android copied to clipboard

Add internal playback of audio files

Open awesome-manuel opened this issue 6 years ago • 14 comments

This is a draft implementation of internal audio playback.

Pull Request Checklist

  • [x] Changes has been tested on an Android device or Android emulator with API 16
  • [x] UI change has been tested on both light and dark themes
  • [x] Pull request is based on the develop branch
  • [x] Pull request updates CHANGES.rst
  • [x] Pull request includes screenshots or videos if containing UI changes
  • [x] Pull request includes a sign off

awesome-manuel avatar Jul 09 '19 14:07 awesome-manuel

Here are some screenshots of how this looks: Screenshot_20190902-154556_AMPchat Screenshot_20190902-154607_AMPchat Screenshot_20190902-154649_AMPchat

intsven avatar Sep 02 '19 13:09 intsven

Hi @awesome-manuel , Thanks for the PR. After a quick review, the code LGTM. I will check at runtime. FTR the core team is working more on RiotX now, but if all is Ok, I will merge the PR anyway.

bmarty avatar Sep 02 '19 15:09 bmarty

Pb I see so far:

  • mp3 playback does not work. I haven't tested other format yet.
  • When scrolling, the button state (play/pause) is not restored

bmarty avatar Sep 02 '19 15:09 bmarty

When scrolling, the button state (play/pause) is not restored

What do you mean by that? When I scroll everything just keeps working like you would expect it

intsven avatar Sep 03 '19 11:09 intsven

mp3 playback does not work. I haven't tested other format yet.

I usually use audio/mp4. Do we really need mp3 support because the Android MediaRecorder does not even support recording mp3?

intsven avatar Sep 03 '19 11:09 intsven

Maybe fall back to download in case of MP3?

awesome-manuel avatar Sep 03 '19 16:09 awesome-manuel

I have tested mp3 now and it works for me inline just as the other audio messages (m4a, ...). I tested this file: https://ia802508.us.archive.org/5/items/testmp3testfile/mpthreetest.mp3

intsven avatar Sep 04 '19 09:09 intsven

Can someone explain what this means exactly?

$ ./tools/check/check_code_quality.sh
Check drawable quantity
ERROR, missing drawable alternative.

awesome-manuel avatar Sep 17 '19 10:09 awesome-manuel

@awesome-manuel Could you add Support 4 .ogx files like WhatsApp ? It won't playback currently only over a Third Party Media Player possible, I think .ogx is Opus based Audiofile in my mind.

DoM1niC avatar Oct 10 '19 15:10 DoM1niC

@bmarty any chance we can get this merged at all?

awesome-manuel avatar Dec 09 '19 10:12 awesome-manuel

Sorry if this is not the correct place to ask, but does this mean this will be included in the next version?

ghost avatar Feb 15 '20 23:02 ghost

Is there anything to take here for RiotX? At least the design principles?

tuxayo avatar Mar 18 '20 21:03 tuxayo

RiotX issue: https://github.com/vector-im/riotX-android/issues/29

tuxayo avatar Mar 18 '20 21:03 tuxayo

the play and pause icons appear even when the files are not audio, also it does not play all some formats like mp3 p m4a

LarzlRael avatar Dec 09 '20 21:12 LarzlRael