pwa-asset-generator icon indicating copy to clipboard operation
pwa-asset-generator copied to clipboard

Add Support for custom browser path

Open max-programming opened this issue 4 years ago • 0 comments

Is your feature request related to a problem? Please describe. Just discovered it's an amazing package that lets us generate assets for a PWA. But as it uses puppeteer-core, it's better if we don't find Chrome on a user's system, they can enter the path of the Chromium-based browser they might be using.

For eg. Microsoft Edge, Brave, Chrome (Beta, Dev or Canary version)

Describe the solution you'd like Adding a flag to take the path input or a prompt asking "Enter the path of your Chrome or Chromium-based browser".

Additional context As I had Microsoft Edge installed on my system, I thought it would maybe ask for the path or take the existing MS Edge path from env variables If the user is on Windows. But it didn't and as I didn't have Chrome installed, it was downloading Chromium.

max-programming avatar Aug 14 '21 02:08 max-programming