electron-api-demos icon indicating copy to clipboard operation
electron-api-demos copied to clipboard

Custom protocols not showing the error box on windows

Open jbleuzen opened this issue 9 years ago • 5 comments

  • What operating system are you using? Windows 10
  • What version of Node.js is on your system? None

I tried to use your demo of custom protocols because it's supposed to be supported on OSX and Windows :

screen shot 2016-10-13 at 16 32 33

I made some tests and it works perfectly on OSX, the error box is popping, telling me what URI I clicked on. But on Windows, the error box doesn't appear, only the application is popping.

As far as I understand :

  • the error box is displayed because app.on('open-url') is only available on macOS
  • the application is displayed on Windows thanks to `

My point is it possible to implement a way to show the error box on Windows ?

You might want to check PR #270 as well.

jbleuzen avatar Oct 13 '16 16:10 jbleuzen

Hi @jbleuzen, I want to make sure I understand which part of this demo fails. I'm running on Windows 10 as well. When I click the "View Demo" button, it launches my default browser to a page that looks like...

image

When I click that button, I get the following error dialog:

That looks like a bug to me. We must not be keeping the path to the application in the registry up to date. What exactly happens in your situation?

haacked avatar Oct 13 '16 23:10 haacked

@Haacked That isn't a bug I don't think, that is you running from source right? If you use the packaged version this issue shouldn't occur as the default_app is not packaged.

Perhaps we need to add a note indicating this?

MarshallOfSound avatar Oct 14 '16 01:10 MarshallOfSound

@Haacked The thing that fail in the demo is that I expect to see a similar popup on Windows :

screen shot 2016-10-14 at 10 36 44

When launching application in dev, I get the browser opening the green page but when I click on the link electron-api-demos://open the windows application get focus and that's all... I don't get the previous popup with the url

Maybe you should just change the scenario to only work on OSX… Or there is a way to implement the catching of the url and display the popup with the right value ?

jbleuzen avatar Oct 14 '16 08:10 jbleuzen

A note right inside of that demo is also required to stop this bug reports popping out.

kof avatar Nov 22 '16 08:11 kof

A

localsystemmee avatar Mar 22 '18 15:03 localsystemmee