Emmanuel Lécharny

Because of line 802 and following: ``` maven-compiler-plugin ${version.compiler.plugin} UTF-8 1.7 1.7 true true true ``` It's fixed, btw.

Hmmm, the patch has been merged, but the tests are failing: the positive tests are OK, but the negative ones aren't. Also the TLS protocol is not anymore supported by...

Actually, all the handshakes are passing, which make the *shouldFailXXX* tests failing. Here is the modified test class for MINA 2.2.X: ``` package org.apache.mina.filter.ssl; import org.apache.mina.core.filterchain.DefaultIoFilterChainBuilder; import org.apache.mina.core.filterchain.IoFilterChain; import org.apache.mina.core.service.IoHandlerAdapter;...

FTR, here is a part of the logs I get when running the test with Java8: ``` javax.net.ssl|FINE|0F|CLIENT|2023-05-08 22:21:32.416 CEST|SSLExtensions.java:173|Ignore unavailable extension: supported_versions javax.net.ssl|FINE|0F|CLIENT|2023-05-08 22:21:32.417 CEST|ServerHello.java:955|Negotiated protocol version: TLSv1.2 javax.net.ssl|FINE|0F|CLIENT|2023-05-08...

On the test, we use a custom SSLFilter which sets the peer: ``` protected SSLEngine createEngine(IoSession session, InetSocketAddress addr) { //Add your SNI host name and port in the IOSession...

Note that MINA 2.2.X don't have anymore a **PEER_ADDRESS** attribute, so we have to go through the creation of a dedicated **SslFilter** class, which extends the default **SslFilter** class. Not...

Also tested something: using the **sniHostNames** instead of doing a _peer.getHostString()_, changes nothing...

Hi, I confirm the first branch (_ssl_endpoint_algorithm_) works. It mimics MINA_2.1.X, using a PEER attribute. I was also able to have the tests passing with the original code, by changing...

Ok, I pushed the modified code with the working tests!

yes, I followed John's advice and used the new pattern (ie develop a custom SSLFilter inheriting the base SSLFilter to pass a new attribute). We may discuss this pattern though,...