kibana icon indicating copy to clipboard operation
kibana copied to clipboard

Published 20 hours ago • verified publisher icon elastic

[search source] Simplify / refactor flatten method

Open mattkime opened this issue 1 year ago • 2 comments

Summary

The SearchSource flatten method does a lot of object mutation and has a lot of long conditional statements. I'm breaking code out into functions and reducing the amount of object mutation.

Part of https://github.com/elastic/kibana/issues/182068

mattkime avatar May 10 '24 03:05 mattkime

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

elasticmachine avatar May 10 '24 13:05 elasticmachine

/ci

mattkime avatar May 12 '24 22:05 mattkime

:green_heart: Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 418.7KB 418.9KB +225.0B

History

  • :green_heart: Build #209325 succeeded 688217192e4bef8e1df8433ea29f327800b5b6ae
  • :green_heart: Build #209310 succeeded adaefc5777844b45f670652cecf8c924b0159fd6
  • :broken_heart: Build #209294 failed b275cc32791ddf6f4ebe72d73baa0c12e37e060d
  • :broken_heart: Build #209108 failed 83e469d5ace9eaae616bcec050facfde10f7087b

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @mattkime

kibana-ci avatar May 12 '24 23:05 kibana-ci