kibana Bumping EUI to version 67.1.2

Summary

[email protected] ⏩ [email protected]

`67.1.2`

Bug fixes

Fixed EuiFlyout not correctly merging passed css (#6248)
Fixed EuiNotificationEvent not correctly merging passed classNames (#6248)
Fixed EuiAvatar to no longer mutate the object passed to its style prop (#6251)

`67.1.1`

Bug fixes

Fixed EuiDataGrid's broken fullscreen mode when nested within an EuiAccordion (#6235)
Fixed EuiPageSection not correctly merging contentProps.css (#6239)
Fixed EuiPageHeaderContent not correctly merging passed classNames (#6239)
Fixed EuiAccordion not correctly merging buttonProps.css and arrowProps.css (#6239)
Fixed EuiProgress not correctly merging labelProps.css (#6239)
Fixed EuiImage not correctly merging wrapperProps.css (#6239)

CSS-in-JS conversions

Converted EuiFlyout to Emotion; Removed $euiFlyoutBorder and $euiFlyoutPaddingModifiers (#6213)

`67.1.0`

Added an optional dev-mode check to log, warn, or error if a component is rendered outside of EuiProvider (#6216)
Updated EuiBadge's disabled styling to match EuiButton (#6224)
Added the custom_component search filter type for the EuiSearchBar. This new type gives the consumer control to render the search filter dropdown. (#6226)

Bug fixes

Fixed Query.toESQuery() to generate bool queries instead of relying on match query logic, to work with non-text fields (#6220)
Fixed EuiInMemoryTable's internal state tracking to include changes of sorting.sort values (#6228)
Fixed bug in EuiButton where iconSize was not being applied (#6230)

CSS-in-JS conversions

Converted EuiBadge to Emotion (#6224)

`67.0.0`

Updated EuiSuggest to accept the isPreFiltered prop (#5930)
Updated EuiOverlayMask to use EuiPortal (#6090)
Updated EuiToolTipPopover to be a function component (#6104)
Added EuiToolTipAnchor and EuiToolTipArrow components (#6104)
Added a new component prop to EuiPageSection, allowing overriding of the default section tag (#6192)

Bug fixes

Fixed global styles being inserted into the wrong location when a EuiProvider cache is not configured. (#6202)
Fixed bug where className and rest props were not being passed to the EuiNotificationEvent (#6208)
Fixed various nested componentProps throwing type errors on the css prop (#6211)

Deprecations

Added @deprecated flags to EuiPageContent_Deprecated, EuiPageContentBody_Deprecated, EuiPageContentHeader_Deprecated, EuiPageContentHeaderSection_Deprecated, EuiPageSideBar_Deprecated and EuiPageTemplate_Deprecated, which will provide helpful hints to IDEs that support jsdoc flags. Consumers will have until August 2023 to migrate from these deprecated components. (#6194)

Breaking changes

Removed onClick prop from EuiOverlayMask. Use a nested EuiFocusTrap instead. (#6090)
Removed euiCallOutColor Sass mixin (#6201)

CSS-in-JS conversions

Converted EuiOverlayMask to Emotion (#6090)
Converted EuiToolTip to Emotion styling (#6104)
Converted EuiPagination, EuiPaginationButton, and EuiPaginationButtonArrow to Emotion (#6109)

`66.0.0`

Added the gutterSize prop to EuiDescriptionList (#6175)
Added tooltipText as an optional prop on EuiListGroupItem (#6186)

Bug fixes

Updated the EuiHeaderSectionItem to not render if empty (#6158)
Added memoization to useEuiTheme's return value, supporting React's shallow prop comparison optimizations (#6165)
Fixed an EuiPageSidebar bug where inline styles were not correctly updating (#6191)

Breaking changes

Removed .euiIEFlexWrapFix global className and internetExplorerOnly() Sass mixin, as IE is no longer a supported browser (#6154)
Removed all IE fixes/fallbacks in EUI CSS (#6161)
Removed all IE fixes/fallbacks in EUI JS (#6162)

`65.0.2`

Bug fixes

Fixed missing EuiDataGrid cell popover shadows in Safari (#6163)
Fixed a bug in some development environments which prevented EuiIcon from loading icons asynchronously (#6166)
Updated the build process to include json files, fixing imports from the @elastic/eui package (#6172)

`65.0.1`

Note: this version contains a bug preventing its usage, fixed in 65.0.2

Bug fixes

Fixed the text size of EuiDescriptionListTitle when EuiDescriptionList is compressed (#6160)

`65.0.0`

Note: this version contains a bug preventing its usage, fixed in 65.0.2

Added anchorProps to allow passing more props to the anchoring wrapper in EuiToolTip and EuiBetaBadge (#6110)
Added an empty shade background color to hollow style EuiBetaBadge (#6110)
Changed design of select button in selectable EuiCards (#6110)
Updated button ghost colors to be colorMode = 'dark' themed text buttons (#6150)
Renamed ButtonColor and ButtonSize types to prefixed versions EuiButtonColor and EuiButtonSize (#6150)

Deprecations

Deprecated ghost color for EuiButton, EuiButtonIcon, EuiButtonEmpty (#6150)

Breaking changes

Removed EuiButtonIconColor and EuiButtonEmptyColor types, use EuiButtonIconProps['color'] and EuiButtonEmptyProps['color'] instead (#6150)
Removed support for ghost color from EuiButtonGroup (#6150)

CSS-in-JS conversions

Removed euiHasBetaBadge() Sass mixin (#6110)
Converted EuiCard, EuiCheckableCard to Emotion, removed $euiCheckableCardPadding, $euiCardSpacing, $euiCardBottomNodeHeight, $euiCardSelectButtonBorders, $euiCardSelectButtonBackgrounds, and $euiCardPaddingModifiers (#6110)
Converted EuiButton to Emotion (#6150)
Converted color styles of EuiButtonIcon, EuiButtonEmpty, EuiButtonGroup (#6150)

`64.0.5`

Note: this release is a backport containing changes originally made in 67.1.0, 67.1.1, and 67.1.2

Bug fixes

Fixed EuiInMemoryTable's internal state tracking to include changes of sorting.sort values (#6228)
Fixed EuiDataGrid's broken fullscreen mode when nested within an EuiAccordion (#6235)
Fixed EuiAvatar to no longer mutate the object passed to its style prop (#6251)

Sep 21 '22 18:09 breehall

@elasticmachine merge upstream

Nov 01 '22 03:11 cee-chen

Pinging @elastic/eui-design (EUI)

Nov 01 '22 20:11 elasticmachine

@elasticmachine merge upstream

Nov 01 '22 21:11 cee-chen

@elasticmachine merge upstream

Nov 01 '22 23:11 breehall

Pinging @elastic/apm-ui (Team:APM)

Nov 01 '22 23:11 elasticmachine

Pinging @elastic/uptime (Team:uptime)

Nov 01 '22 23:11 elasticmachine

@davismcphee Looking at EuiBetaBadge, it has a default CSS rule of vertical-align: super which explains why its baseline is higher than normal text. It looks like this CSS rule was in place even pre-Emotion conversion, but it got a little "more" super post-Emotion, if that makes sense (possibly due to baseline typography mixin/line height updates). I would personally suggest overriding the CSS on it to set vertical-align: baseline or vertical-align: middle.

Regarding your flyout screenshot - I'm testing locally and I can't reproduce this in any flyout on Firefox or Chrome. Just to check, have you ensured you've bootstrapped / hard refreshed / etc to clear out any stale or cached styles?

Nov 02 '22 17:11 cee-chen

Quick re-ping to all pending codeowners: @elastic/kibana-operations @elastic/security-solution-platform @elastic/kibana-reporting-services @elastic/kibana-app-services @elastic/observability-design @elastic/security-detections-response-alerts @elastic/uptime @elastic/apm-ui @elastic/infra-monitoring-ui

We're planning to ask for an admin-merge by EOD Friday with or without all approvals in order to give everyone enough time to QA/account for changes before 8.6FF - we'd appreciate your reviews!

Nov 04 '22 00:11 cee-chen

ResponseOps changes LGTM. I am not sure if it is related to this PR but found this in lens:

cc @stratoula

@cnasikas Thanks for bringing this up! I just pushed an update to apply text truncation to that button when the name gets long to prevent it from spilling out of the container

Nov 04 '22 15:11 breehall

@cnasikas thanx for finding this. This doesn't happen in main.

Nov 04 '22 15:11 stratoula

For selectable EuiCard components, in security solution rules edit/create page, selectable button changed its position:

PR Branch

Main

link to EuiCard usage in code

Nov 04 '22 18:11 vitaliidm

@vitaliidm thanks for the report! I pushed up a temporary fix until we can resolve an issue with horizontal selectable cards in EUI. This same situation also happened in osquery's live query & canvas's datasource selector.

Nov 05 '22 04:11 chandlerprall

:yellow_heart: Build succeeded, but was flaky

Buildkite Build
Commit: 20e6ead5713781c35fdd15c73e9886f9abcecfac
Storybooks Preview

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`canvas`	1098	1111	+13
`infra`	964	969	+5
`visTypeVega`	168	307	+139
total			+157

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`advancedSettings`	46.9KB	46.7KB	-274.0B
`apm`	3.1MB	3.1MB	-9.0B
`canvas`	1.0MB	1.0MB	+6.5KB
`cases`	334.3KB	334.3KB	+1.0B
`controls`	473.6KB	473.5KB	-54.0B
`dataViewFieldEditor`	154.4KB	154.4KB	-62.0B
`dataVisualizer`	537.0KB	537.0KB	-54.0B
`discover`	412.9KB	412.8KB	-108.0B
`enterpriseSearch`	1.8MB	1.8MB	-46.0B
`expressionLegacyMetricVis`	12.0KB	11.9KB	-54.0B
`expressionXY`	118.8KB	118.8KB	+3.0B
`graph`	432.9KB	432.9KB	-54.0B
`home`	157.9KB	157.9KB	+2.0B
`infra`	976.4KB	980.3KB	+3.9KB
`lens`	1.3MB	1.3MB	+1.6KB
`maps`	2.7MB	2.7MB	-326.0B
`ml`	3.3MB	3.3MB	-45.0B
`monitoring`	451.8KB	451.7KB	-54.0B
`observability`	495.0KB	495.0KB	+36.0B
`osquery`	1009.6KB	1009.7KB	+68.0B
`securitySolution`	9.6MB	9.6MB	+12.7KB
`timelines`	74.0KB	73.9KB	-114.0B
`triggersActionsUi`	652.8KB	652.7KB	-54.0B
`unifiedSearch`	216.2KB	216.2KB	-62.0B
`visTypeTable`	16.2KB	16.2KB	-54.0B
`visTypeTimeseries`	509.3KB	509.2KB	-108.0B
`visTypeVega`	1.6MB	1.8MB	+146.2KB
`visTypeVislib`	348.9KB	349.0KB	+81.0B
total			+169.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`canvas`	13.3KB	13.3KB	+56.0B
`core`	376.8KB	377.0KB	+125.0B
`embeddable`	69.1KB	69.0KB	-116.0B
`kbnUiSharedDeps-css`	438.5KB	374.5KB	-64.0KB
`kbnUiSharedDeps-npmDll`	5.1MB	5.1MB	+32.7KB
`kibanaReact`	52.1KB	51.9KB	-202.0B
`presentationUtil`	43.2KB	43.2KB	+10.0B
`savedObjects`	29.1KB	29.1KB	+24.0B
`searchprofiler`	21.4KB	19.8KB	-1.6KB
`unifiedSearch`	49.7KB	49.7KB	+51.0B
`visTypeVega`	33.6KB	33.6KB	+58.0B
total			-32.9KB

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	58	64	+6
`osquery`	108	113	+5
`securitySolution`	440	446	+6
total			+19

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	66	72	+6
`osquery`	109	115	+6
`securitySolution`	517	523	+6
total			+20

History

:broken_heart: Build #85641 failed cfbd4dedc9ae134ff759f9f322a5af66b31d8d21
:broken_heart: Build #85640 failed c605cbd7b92311b76f05ed1d6fab0651eeeae0cb
:green_heart: Build #85639 succeeded 37b192216994dcace771b7583c188ad88bf124ec
:broken_heart: Build #85632 failed 16ce9f801735c7c5fcf8670e2157716d4fc0c737
:green_heart: Build #85512 succeeded 34007a4fd529c4b9493cb238885c82b5be6e6b8f
:broken_heart: Build #85468 failed b21d6030c83f259d9ee2d186ffe8896b8b25ed97

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

Nov 06 '22 04:11 kibana-ci

Vega specs which add scrolls don't work correctly.

@stratoula this sounds similar to Andrew's finding. Would this be the same change you're referring to? Also, do you mind telling me how I can find the view you're referencing?

Nov 07 '22 14:11 breehall

@breehall Go to Visualize, Create a new visualization and click Custom Visualization

There copy paste the spec I sent you.

Nov 07 '22 14:11 stratoula

Vega specs which add scrolls don't work correctly.

@stratoula I just pushed a change for this. Do you mind verifying that you see the scroll bars on your end?

This is what I'm able to see now:

5A16AA3C-88C0-49C0-874C-E950A77758A9

Nov 07 '22 15:11 breehall

@elasticmachine merge upstream

Nov 07 '22 18:11 breehall