eui icon indicating copy to clipboard operation
eui copied to clipboard

Published 20 hours ago • verified publisher icon elastic

[EuiComboBox] [EuiSelectable] allow for highlighting a custom fragment when using custom option matcher

Open mbondyra opened this issue 1 year ago • 2 comments

While testing https://github.com/elastic/eui/pull/7709 I noticed that while passing a custom optionMatcher we cannot highlight the substring that is matched. It'd be good to add it in some way.

Here the fragment get highlighted: Screenshot 2024-04-25 at 14 11 27

Here it is not, as it comes from the custom matcher check: Screenshot 2024-04-25 at 14 11 43

mbondyra avatar Apr 25 '24 12:04 mbondyra

@tkajtoch do you mind baking this into #7709? Also @mbondyra feel free to leave this as a comment on the PR itself since it hasn't been merged yet!

edit: Oh wait, super sorry, I think I misread the ask. This makes sense to do as a follow-up PR instead of in the same PR

cee-chen avatar Apr 25 '24 16:04 cee-chen

I think this is a nice-to-have, unless this is a super quick fix, we can cancel it.

teresaalvarezsoler avatar May 30 '24 08:05 teresaalvarezsoler