grpc-akka-stream-subrepo

grpc-akka-stream-subrepo copied to clipboard

Hi @eiennohito

I find your code useful, but wanted to let you know that

$ sbt test
[info] Loading project definition from /Users/asko/Sources/grpc-akka-stream-subrepo.akauppi/project
[info] Updating {file:/Users/asko/Sources/grpc-akka-stream-subrepo.akauppi/project/}grpc-akka-stream-subrepo-akauppi-build...
[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[info] Done updating.
[info] Set current project to grpc-streaming (in build file:/Users/asko/Sources/grpc-akka-stream-subrepo.akauppi/)
[info] Updating {file:/Users/asko/Sources/grpc-akka-stream-subrepo.akauppi/}grpc-streaming...
[info] Resolving jline#jline;2.14.1 ...
[info] Done updating.
[info] Compiling 16 Scala sources to /Users/asko/Sources/grpc-akka-stream-subrepo.akauppi/target/scala-2.12/classes...
[warn] /Users/asko/Sources/grpc-akka-stream-subrepo.akauppi/src/main/scala/org/eiennohito/grpc/stream/impl/ServerAkkaStreamHandler.scala:112: match may not be exhaustive.
[warn] It would fail on the following input: (_, _)
[warn]         val actor = getStageActor {
[warn]                                   ^
[warn] there was one deprecation warning (since ScalaPB 0.5.47); re-run with -deprecation for details
[warn] two warnings found
[success] Total time: 13 s, completed Jun 6, 2017 10:52:12 AM

Expected:

• tests to have been run, and passed

Actual:

• compilation warning, but also "success" state. Kind of weird?

I'll have a look if I can get tests to run. This is just a heads up.

I have a pretty rough week till sunday, so I'll look into the issue next week.

Tests are in subproject (because of codegen) and are not run from the main project. Simply doing an aggregation did not work for me. Some more explicit sbt configuration should be done.