edgedb-python

edgedb-python copied to clipboard

Working towards https://github.com/edgedb/edgedb-python/issues/296

I have never touched a c extension before :/

@elprans @fmoor I think we should pause and re-evaluate if we can just use standard Python tuple instead of a custom edgedb.Tuple. We'll still have to have edgedb.NamedTuple fwiw, but I don't see any support of new slicing capabilities added to it. Why?

We'll still have to have edgedb.NamedTuple fwiw, but I don't see any support of new slicing capabilities added to it. Why?

I had never worked on a C extension before so I was starting small.

I had never worked on a C extension before so I was starting small.

NP, but since this is now done and looks good, I suggest to generalize the functions into _EdgeGeneric_* family and reuse them from both the namedtuple and tuple (because both types support slicing etc).

Closing this one -- we got rid of edgedb.Tuple