ecodina
ecodina
> Good work, just a couple of questions for my understanding: > > 1. What's "All states" required for? Maybe "Running" and "Failed" can just work with the existing "All",...
> Might it be cleaner to just unselect failed? There are only two buttons, so I don't know that it makes sense to include an "all states" button when there...
@bbovenzi done! Similarly to the tags I added the "reset_filter" param to reset the cookie when we deselect the filter. However, the user does not see it, since it immediately...
> I agree that the count for Running and Failed should just be the count of dags and not runs. > > I am less sure if we only want...
Thanks @eladkal for finding it! Following your concern (mixing Dag and DagRun properties) I believe that adding this should be "simple": Instead of having: `arg_status_filter = request.args.get("status")` We should have...