jsonforms icon indicating copy to clipboard operation
jsonforms copied to clipboard

Published 20 hours ago • verified publisher icon eclipsesource

Set `type` of `<button>`s in vanilla array renderer

Open joefreeman opened this issue 1 year ago • 3 comments

This updates the <button>s in the vanilla array renderer to set the type to "button". This allows a <JsonForms> to be contained within a <form> without these buttons triggering a submit of the form.

I believe this is fixing the same issue as #1731, but for the vanilla renderers.

joefreeman avatar Mar 06 '24 18:03 joefreeman

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 06 '24 18:03 CLAassistant

Deploy Preview for jsonforms-examples ready!

Name Link
Latest commit b215b7412b13795bf32c8c283df127b0a7dbef78
Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65eadf6335120200089fe6d2
Deploy Preview https://deploy-preview-2298--jsonforms-examples.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 06 '24 18:03 netlify[bot]

Thanks for the contribution :heart:. The change looks good! Can you fix the linter errors?

sdirix avatar Mar 08 '24 09:03 sdirix

Coverage Status

coverage: 84.881%. remained the same when pulling b215b7412b13795bf32c8c283df127b0a7dbef78 on joefreeman:vanilla-button-types into 30c1b79fbb9373bc2afacebc22943b6129eb1be6 on eclipsesource:master.

coveralls avatar Mar 08 '24 11:03 coveralls