jsonforms icon indicating copy to clipboard operation
jsonforms copied to clipboard

Published 20 hours ago • verified publisher icon eclipsesource

Allow the translation of enum value used for elementLabelProp in ExpandPanelRenderer

Open Maxouwell opened this issue 1 year ago • 3 comments

PR for #2288

Maxouwell avatar Feb 19 '24 15:02 Maxouwell

Deploy Preview for jsonforms-examples ready!

Name Link
Latest commit 4284d6e63209acb801f110771219171cf1ebf7e4
Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66212991139e7e00088d46ed
Deploy Preview https://deploy-preview-2289--jsonforms-examples.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 19 '24 15:02 netlify[bot]

Coverage Status

coverage: 83.269% (-1.6%) from 84.881% when pulling 4284d6e63209acb801f110771219171cf1ebf7e4 on Maxouwell:fix/material-array-layout-translated-enum-label-prop into 24f4e5f6280263a4b8e1263aa2a302613b546272 on eclipsesource:master.

coveralls avatar Feb 20 '24 09:02 coveralls

Resolved the conflicts, rebased and squashed

Maxouwell avatar Feb 20 '24 11:02 Maxouwell

You were right, the previous code had problems on translation key, and on elementLabelProp on deeper path.

I fixed it and added some tests for the deep cases.

Maxouwell avatar Mar 08 '24 17:03 Maxouwell

I just saw that the same behaviour exist in ListWithDetail, and that the solution don't support if elementLabelProp point to an enum array (or oneOf array if it's a thing). I propose we finish this PR and I will open others PRs for these other ones.

Maxouwell avatar Mar 18 '24 09:03 Maxouwell

Update: I will re-review this PR again this week

sdirix avatar Apr 15 '24 16:04 sdirix