che-che4z-lsp-for-cobol icon indicating copy to clipboard operation
che-che4z-lsp-for-cobol copied to clipboard

Published 20 hours ago • verified publisher icon eclipse

Feature/workspace/extension folder

Open KutluOzel-b opened this issue 1 year ago • 4 comments

Changed copybook download folder from {workspace} /.c4z/.copybooks/... into {global storage folder}/.zowe/.copybooks/...

added 'open internal copybook folder command' to add copybook download folder to open workspaces

How Has This Been Tested?

Apply copybook settings as regular and try it out. nothing specific needed to test this.

Checklist:

  • [x] Each of my commits contains one meaningful change
  • [x] I have performed rebase of my branch on top of the development
  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] I have checked my code and corrected any misspellings

KutluOzel-b avatar Apr 03 '24 09:04 KutluOzel-b

Please also fix integration tests and squash commits

ishche avatar Apr 08 '24 08:04 ishche

I think that the relative paths in the user settings should not be used in combination with the new download directory - please add a test for this situation.

slavek-kucera avatar Apr 17 '24 12:04 slavek-kucera

I think that the relative paths in the user settings should not be used in combination with the new download directory - please add a test for this situation.

added test for this : 04536b2dc26625835275533f485648f299ec8f2c

KutluOzel-b avatar Apr 18 '24 11:04 KutluOzel-b

Could you please resolve conflicts, clean up the PR description, and squash commits?

ishche avatar Apr 22 '24 09:04 ishche