easybuild-framework icon indicating copy to clipboard operation
easybuild-framework copied to clipboard

added support for checking out svn revisions to download_file

Open JensTimmerman opened this issue 10 years ago • 22 comments

This works for easyconfig files looking like this (if pysvn and tar are available on the system):

name = 'FDS'
version = '20564'

homepage = 'https://code.google.com/p/fds-smv/'
description = """
 Fire Dynamics Simulator (FDS) is a large-eddy simulation (LES) code for low-speed flows, with an emphasis on smoke and
 heat transport from fires.
"""
toolchain = {'name': 'foss', 'version': '2014b'}
toolchainopts = {'pic': True, 'usempi': True}

source_urls = ['svn+http://fds-smv.googlecode.com/svn/trunk/FDS/trunk/']

sources = ['%(version)s.tar.gz']
moduleclass = 'phys'

note the 'svn+http' part in the source_urls, this is needed to tell the download function to use svn. version is used as the revision number to check out, sources are currently always '%(version)s.tar.gz' Sine this code checks out the svn repo at the given revision, creates a tarball, and removes it again.

JensTimmerman avatar Oct 30 '14 17:10 JensTimmerman

Why put the sources to '%(version)s.tar.gz'? I would drop the .tar.gz. Gives us the freedom to changes if we want later on and, if you have multiple source_urls and sources, of which some are svn and some are not, this is hard. I'm more in favor of a something like %(SVN_VERSION_REV)s. So that it is clear which ones are svn and which should go to normal http.

wpoely86 avatar Oct 30 '14 17:10 wpoely86

Test FAILed.

hpcugentbot avatar Oct 30 '14 17:10 hpcugentbot

The sources get downloaded and saved as %(version)s.tar.gz in the sources directory, as per your idea as discussed on irc.

JensTimmerman avatar Oct 31 '14 14:10 JensTimmerman

Test FAILed.

hpcugentbot avatar Oct 31 '14 14:10 hpcugentbot

Test PASSed.

hpcugentbot avatar Nov 03 '14 11:11 hpcugentbot

I'm working on a python implementation for creating a tarball, got it working locally but need some more testing, so please hold on from merging or making any changes

JensTimmerman avatar Nov 06 '14 09:11 JensTimmerman

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1269/ Test FAILed.

hpcugentbot avatar Feb 09 '15 10:02 hpcugentbot

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1270/ Test FAILed.

hpcugentbot avatar Feb 09 '15 10:02 hpcugentbot

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1271/ Test FAILed.

hpcugentbot avatar Feb 09 '15 11:02 hpcugentbot

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1272/ Test FAILed.

hpcugentbot avatar Feb 09 '15 13:02 hpcugentbot

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1273/ Test PASSed.

hpcugentbot avatar Feb 09 '15 14:02 hpcugentbot

this is ready to be merged in, it works, except for the fact that svn is very slow :tongue:

JensTimmerman avatar Feb 09 '15 14:02 JensTimmerman

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1274/ Test PASSed.

hpcugentbot avatar Feb 09 '15 16:02 hpcugentbot

@JensTimmerman: not exactly ready to be merged in, but it's starting to look really nice! Let's try and get this in soon, to avoid leaving it to rot again...

boegel avatar Feb 09 '15 23:02 boegel

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1282/ Test FAILed.

hpcugentbot avatar Feb 10 '15 11:02 hpcugentbot

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1283/ Test FAILed.

hpcugentbot avatar Feb 10 '15 11:02 hpcugentbot

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1284/ Test FAILed.

hpcugentbot avatar Feb 10 '15 13:02 hpcugentbot

Jenkins: test this please

boegel avatar Feb 11 '15 00:02 boegel

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1294/ Test FAILed.

hpcugentbot avatar Feb 11 '15 02:02 hpcugentbot

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1322/ Test FAILed.

hpcugentbot avatar Feb 11 '15 17:02 hpcugentbot

@boegel @JensTimmerman Is this still relevant?

akesandgren avatar Sep 09 '19 10:09 akesandgren

Ping @boegel and @JensTimmerman again

akesandgren avatar Feb 10 '20 07:02 akesandgren