Dylan Simon

Results 115 comments of Dylan Simon

Yes, currently it crashes if you specify `--unix-target` and a wrap command, and you get strange errors with `--unix-listen` and a wrap command. I realize now neither of these are...

I guess I should add (and probably document) that for [obscure jupyterlab reasons](https://github.com/jupyterlab/jupyterlab/blob/cfa3f5b94ecdddef8a085b397963e87a0066b559/packages/launcher/src/widget.tsx#L119), the `icon_path` setting will only work when `category` is either `"Kernel"` or `"Console"`.

I looked into the other icons a little, and it seemed more complicated. I think @bollwyvl's suggestion could be made to work in a generic way. I can try to...

Thanks, yeah I understand the concerns, but having worked on the websockify code as well, I can at least say that this PR is overall much simpler and easier to...

Okay, I think everything has been addressed now. Option is now named `raw_socket_proxy`, and there are a couple tests with a simple tcp and unix socket server backend. Let me...

Thanks. I put a dump [here](https://users.flatironinstitute.org/~dylan/support/mayastor-2024-01-15--16-14-35-UTC.tar.gz) though looking at the logs I think it did not capture the relevant period due to restarts. We do have the logs externally from...

Ah, yeah, we're already collecting all logs with filebeat, so prefered not to duplicate. If I'm reading that correctly, this probably needs the `nvme_core.multipath=Y` kernel parameter (`CONFIG_NVME_MULTIPATH=y` already)? Yeah, I...

I guess this is more complicated than I thought. I can see how https://github.com/fpco/streaming-commons/blob/master/Data/Streaming/ByteString/Builder.hs#L78 (that `builderToByteString` uses) could be less efficient for this, though now I realize there may be...

In this case happen to be in IO, but I see how making the IO-specific version of `sourceBuilder` to avoid laziness would be overly restrictive. I suppose I'd suggest the...

There might not be all that many down casts -- like how your approach to events manages to avoid them -- but yeah they're unavoidable in some cases. It's the...