effective-shell icon indicating copy to clipboard operation
effective-shell copied to clipboard

chore(main): release 0.26.0

Open wjantispam opened this issue 3 years ago • 1 comments

Fix a typo for https://effective-shell.com/part-4-shell-scripting/mastering-conditional-logic#the-test-command

if ! [ -d ~/backups]
                            ^ missing a space
then
    echo "Creating backups folder"
    mkdir ~/backups
fi

wjantispam avatar Jul 25 '22 12:07 wjantispam

Hi I was trying to submit a PR to correct the typo found in the https://effective-shell.com/part-4-shell-scripting/mastering-conditional-logic#the-test-command but had permission error. Could you please guide me here?

gh pr checkout 229
vim index.md
git add index.md
git commit -m "Fix: Fix a typo in the "test" command"
    1 file changed, 1 insertion(+), 1 deletion(-)
git push
   remote: Permission to dwmkerr/effective-shell.git denied to wjantispam.
   fatal: unable to access 'https://github.com/dwmkerr/effective-shell.git/': The requested URL returned error: 403

wjantispam avatar Jul 25 '22 12:07 wjantispam

Fixed in https://github.com/dwmkerr/effective-shell/pull/242

dwmkerr avatar Jan 17 '23 13:01 dwmkerr