duckdb-rs

duckdb-rs copied to clipboard

Maybe I missed it, but I couldn't see how to insert a row if one of the columns is e.g. TEXT[]. I naively tried params![a_vec_of_str] but ToSql is only implemented for Vec<u8> (I guess for blobs).

The DuckDB docs aren't super clear but it looks like you're supposed to use list_create('a', 'b', 'c') but I'm not sure how to do that with params![].

Haven’t been supported in rust yet

@wangfenjin appreciate your work! Just want to insert here that missing insert of lists is a deal breaker for my projects. Hope to see that implemented soon. Cheers!

Recent support for Union types too. 👍🏼 Natural fits with Rust's enum.

Hope this feature can be supported. If you don't have time, I can write a PR for that.

@neverchanje it'll be great if you can help. Thanks

Would be great if we could also be able to retrieve SRUCT, MAP, ENUMs and UNION along with being able to insert them. I think the insert just needs string representation vs the retrieval needs to be convert from arrow format?

Am I correct @wangfenjin ?

Correct.

1. If you want to support bind struct or other type as params, you may need to update bind_params
2. If you want to support parse sql result as rust native datatypes like map, you may need to update get
3. If it's a new native datatypes, you need to impl the FromSql and ToSql trait, example serde_json
4. You may also want to add new type to enum Value when necessary, if you do that compiler will teach you multiple related places that also need to updated

@Swoorup

The overall idea is in order to make it easier for users, we need to implement the convert logic of from/to sql. After doing this, you will be more familiar with the rust API and also the C API

And please add some tests to the new features, feel free to support one type a time

I think struct/enums/unions would likely need some kind of derivation support via proc macros. This is an interesting example for clickhouse client where the author modified serde to enable support for struct <-> row mapping. See klickhouse_derive https://github.com/Protryon/klickhouse

Correct.

1. If you want to support bind struct or other type as params, you may need to update [bind_params](https://github.com/wangfenjin/duckdb-rs/blob/d2f611f922792ec6943a4f65301c81e247864fc0/src/statement.rs#L414)
2. If you want to support parse sql result as rust native datatypes like map, you may need to update [get](https://github.com/wangfenjin/duckdb-rs/blob/d2f611f922792ec6943a4f65301c81e247864fc0/src/row.rs#L544)
3. If it's a new native datatypes, you need to impl the FromSql and ToSql trait, example [serde_json](https://github.com/wangfenjin/duckdb-rs/blob/d2f611f922792ec6943a4f65301c81e247864fc0/src/types/serde_json.rs#L8-L27)
4. You may also want to add new type to enum [Value](https://github.com/wangfenjin/duckdb-rs/blob/d2f611f922792ec6943a4f65301c81e247864fc0/src/types/value.rs#L10) when necessary, if you do that compiler will teach you multiple related places that also need to updated

@wangfenjin If I try like in point 3, it says (edited out the error; I just had to add the relevant features).

Could you show an example, please, of how I can insert a String (valid JSON String) or a Vec<u8> containing a valid JSON String? If I try, I only see the new row as bytes (hex bytes shown in decimal for each character, and not a string). I created the table beforehand with create table tab (col1 STRING). Even tried the type TEXT and JSON. All just get inserted as bytes. Even with the serde_json example, I still see only bytes in decimal inserted into the table.

Will duckdb-rs add native support for Rust data types (struct/enum at least)?