dub icon indicating copy to clipboard operation
dub copied to clipboard

Add support for '_' to allow migration from other URL Shorteners

Open miles202 opened this issue 1 year ago • 6 comments

Dub does not allow for underscores ('_') in the shortened name, which prevents migration from other shorteners that do support it.

miles202 avatar Mar 21 '24 11:03 miles202

@miles202 thanks for the feature request! Do you know which URL shorteners support _? AFAIK the main ones (Bitly, Rebrandly, etc.) don't support it

steven-tey avatar Mar 22 '24 14:03 steven-tey

We are migrating from www.rebrandly.com and have one...just added a new one to test:

https://fieldhub.link/test_one

It allows it and it works.

miles202 avatar Mar 23 '24 01:03 miles202

@miles202 we could potentially allow _, but not as the first character in the key (e.g. fieldhub.link/test_one works, but fieldhub.link/_test wouldn't work). Would that work for you?

steven-tey avatar Mar 23 '24 09:03 steven-tey

Yes that would work perfectly but I am personally ok without it. The few cases where we have it I can change to dash and re distribute the url since they are mostly internal. I just submitted the ticket to make sure there was good support for migrations from the legacy platforms generally. Thanks!!

miles202 avatar Mar 23 '24 10:03 miles202

@steven-tey can u please assign the issue to me, code change identified

vagishfibr avatar Mar 31 '24 10:03 vagishfibr

Underscores is now supported on Dub links (via #1202) 🚀

CleanShot 2024-08-19 at 13 03 54

steven-tey avatar Aug 19 '24 20:08 steven-tey