PyEasyArchive
PyEasyArchive copied to clipboard
dsoprea
Add support for reading and writing encrypted archives with test suites
Pull Request Test Coverage Report for Build 50
- 43 of 52 (82.69%) changed or added relevant lines in 5 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.5%) to 71.443%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| libarchive/adapters/archive_read.py | 11 | 14 | 78.57% |
| libarchive/adapters/archive_write.py | 15 | 21 | 71.43% |
| <!-- | Total: | 43 | 52 |
| Totals | |
|---|---|
| Change from base Build 47: | 0.5% |
| Covered Lines: | 708 |
| Relevant Lines: | 991 |
💛 - Coveralls
I found the issue with Python 2.7, it's related to a call to bytes which works perfectly with Python3 but not Python2. Do I need to add version check to call the right function depending on Py2 or Py3? Do you still want to support Python2.7?
Based on your feedback, I'll commit the patch.
Sorry for the previous commit which only fixed python2 and not python3. Now all tests are green!