Joe Tsai

Results 341 comments of Joe Tsai

Hi @nnutter, I'm sorry to hear that you were broken by the change. The purpose of this project is to comply with the semantics defined by the main protocol buffer...

This still needs to be addressed at https://github.com/protocolbuffers/protobuf/issues as the documentation for `field_mask.proto` is hosted there. AIP documentation is considered to be a lesser degree authority than the `field_mask.proto` documentation...

Annotating errors with this information seems reasonable. If we do this or marshal, we presumably want to do it for unmarshal as well. At least for unmarshal, we removed context...

The logic for formatting the `rawDesc` simply chunks it on 16B boundaries. A single byte insertion/removal at the start will change all subsequent bytes afterwards. If we want to reduce...

It used to be in the past, but not anymore. The space savings from performing gzip was not worth the cost in extra initialization time decompressing the descriptors. The deprecated...

Both `jsonpb` and `protojson` support extensions. For example: https://github.com/protocolbuffers/protobuf-go/blob/8525b20428fdd941303fbebd0e1b1e43dd5f286a/encoding/protojson/encode_test.go#L912-L942 The reason this doesn't appear to work is likely identical to what's going on with #1120

> This is only handled in Golang, right? Correct, extension handling is one of the "features" unique to Go that the other languages don't provide. However, the old implementation provided...

> There's a bit of a chicken or egg problem here though right? In the dynamic case, where you're taking a FileDescriptorSet from an external source and unmarshalling it, you...

Are you using `protodesc.NewFile` or `protodesc.NewFiles` any way along the way? This chicken-and-egg problem is solely unique to dealing with a `FileDescriptorSet` and I'm wondering if the `protodesc` package should...

Going to re-purpose this issue as potentially having `reflect/protodesc` auto-create dynamic extensions. The original issue of having `encoding/protojson` emit extensions already exists.