Joe Tsai

Results 341 comments of Joe Tsai

Assuming this issue is because the data is highly compressible, I don't think we should add an output buffer automatically since memory use of DEFLATE compressors is something that matters...

The purpose of a global `sink` is to work around compiler optimizations that gets rid of the entire `append`. It still demonstrates my point that appending to a slice with...

A search through all public modules known by the module proxy showed no implementations of the `MarshalScalar` and `UnmarshalScalar` methods, so there should be no backwards compatibility concerns.

In my original proposal I argued against the inclusion of sub-64-bit integers since the value can be represented by the larger width kind. However, allowing smaller bit widths may be...

I thought more about precedence order between `MarshalBinary`, `MarshalText`, and `MarshalScalar`. I think we should deliberately stay silent on the issue and leave it to each encoding package to decide...

> I wonder, can we decide to add sub-64-bit integer types later? It's not clear to me whether that would be considered a breaking change given the type parameter. I'm...

@Merovius, per https://github.com/golang/go/issues/56235#issuecomment-1279423011, there were no detected methods of the proposed name according to all code known by the module proxy. > I think encoding/json can do one check if...

No worries at all. The throughput of comments on golang/go issues and discussions is astonishing and unreasonable to expect every person to be at the same level of state.

> we should wait for Go 1.21 to make sure we land the encoder updates and the new implementations of these methods together. Agreed. To be clear, acceptance of this...

Given the **existing** lack of support for `encoding` interface in "asn1", I propose we leave the package unchanged. The package does have `MarshalWithParams` and `UnmarshalWithParams` functions where we can add...