puppetry icon indicating copy to clipboard operation
puppetry copied to clipboard

Improve MacOS Experience

Open skipjack opened this issue 4 years ago • 4 comments

This one is more minor, just a UX improvement. It would be cool to have the native minimize, close window and quit options (cmd + q) work on a Mac. Rather than...

image

I'm recommending we leverage what most other MacOS apps look like, for example VSCode...

image

... with the standard red close, yellow minimize and green maximize buttons.

Not sure what this entails within Electron but I'd be surprised if it's not doable. I've always been interested in Electron and would be happy to take a stab at this though. We need to be careful not to let this improvement break things on the other supported operating systems.

skipjack avatar May 28 '21 13:05 skipjack

Also, related to cmd + q not working, I see something other than the usual "Quit [App Name]" option in the file menu...

image image

skipjack avatar May 28 '21 13:05 skipjack

@dsheiko was there some rationale as to not going with the native options? Maybe Electron doesn't make them easy to do natively across platforms?

skipjack avatar May 28 '21 13:05 skipjack

Looks like it's just because we're using a frameless window here...

https://github.com/dsheiko/puppetry/blob/master/app/main.js#L60

skipjack avatar May 28 '21 14:05 skipjack

I did it so back then because on Windows it looked quite ugly, but you have a point. I'll consider to change it

dsheiko avatar May 28 '21 14:05 dsheiko