ntfy icon indicating copy to clipboard operation
ntfy copied to clipboard

Add support for AstroNote

Open st3fan opened this issue 5 years ago • 3 comments

This patch adds support for AstroNote, which is a small push notifications app for Apple Watch.

I've marked the PR as Draft - I think it is complete but I'd love to hear if @dschep is interested in including this backend and if so, if anything is missing in this patch.

st3fan avatar Sep 20 '20 12:09 st3fan

Coverage Status

Coverage increased (+0.5%) to 81.623% when pulling 50f1853e03a7aa052cafa316ba1634cecca98613 on st3fan:st3fan/astronote into ecfeee960af406a27ebb123495e0ec2733286889 on dschep:master.

coveralls avatar Sep 20 '20 13:09 coveralls

Hey @st3fan, this looks good for the most part. However, some time ago, I added the capability for ntfy to load backends from 3rd party modules, my official recomendation is that you publish this as It's own package, such as ntfy-astronote, that way updates to the astronote backend aren't blocked by me making new releases of ntfy. You can check out my ntfy-webpush library for an example of this: https://github.com/dschep/ntfy-webpush

dschep avatar Sep 21 '20 12:09 dschep

note, for discoverability, I'll still gladly accept a PR adding the new backend to the list of backends just as I've added for webpush once you've published your own package

dschep avatar Sep 21 '20 12:09 dschep