ntfy icon indicating copy to clipboard operation
ntfy copied to clipboard

Add keywords parameters for slack backend

Open AntoinePrv opened this issue 7 years ago • 5 comments

I added keywords parameters in the slack backend to enable other parameters from the config, such as the username and the image (Fancier than the Slack Api Tester default name).

I mentioned it in the readme and also corrected: ~if you use the @ symbol the message is send to a Slack user~ which is no longer supported by Slack Api (only user ids are supported).

Thanks

AntoinePrv avatar Jun 03 '18 16:06 AntoinePrv

Coverage Status

Coverage decreased (-0.6%) to 82.77% when pulling b1a821f237d2fca0248ae0daed27d614e42ffb3f on AntoinePrv:slack into 9b5e7d25bb64513b3f08d1e1ea16cd18eaeed460 on dschep:master.

coveralls avatar Jun 03 '18 16:06 coveralls

No luck with this? Having the sender name as "Slack Api Tester" is pretty annoying.

MACscr avatar Aug 09 '19 12:08 MACscr

That feature would be also useful for me to be able to use different sender icons, depending on the context (e.g. warning vs alert). @dschep Do you plan to accept it (in one way or another) or definitely not and it is required to use a patched version?

szpak avatar May 03 '22 18:05 szpak

i have no issue merging if the merge conflicts were resolved

dschep avatar May 11 '22 15:05 dschep

@AntoinePrv It has been some time, but maybe you still use that feature and would like to have it merged upstream (by resolving the conflicts)? :-/

szpak avatar May 11 '22 16:05 szpak