Denis Rykov

Results 80 comments of Denis Rykov

@penguinolog is it common practice to return `False` as result of comparison of incompatible types? For me personally it looks like problem masking and making debugging more complicated.

This is an upstream issue: ``` In [1]: from rasterio.crs import CRS In [2]: crs = CRS({'init': 'epsg:3857'}) In [3]: crs == 5 --------------------------------------------------------------------------- TypeError Traceback (most recent call last)...

This is consequence of having `nodata=0` in GeoRaster2 constructor. If we change this row: https://github.com/satellogic/telluric/blob/9cabe2a974637297134b711cda8af61628026ec1/telluric/georaster.py#L1598 to: ``` raster = self.copy_with(image=array, affine=affine, nodata=None) ``` then image looks as expected: ![image](https://user-images.githubusercontent.com/866124/43900842-29dea890-9c10-11e8-851c-17163effa6f6.png)

It is expected that shapes in these cases are different (at least from code perspective). Let's see what is happening. First case (crop first): 1 roi.envelope.get_bounds(self.crs) is called inside crop...

If reprojecting first is not a solution you can use `mask` method of GeoRaster: ``` buffer = GeoVector(roi.get_shape(WEB_MERCATOR_CRS).buffer(100), WEB_MERCATOR_CRS) raster.crop(buffer).reproject(dst_crs=WEB_MERCATOR_CRS).mask(roi).save(output_raster) ``` Example of output: ![image](https://user-images.githubusercontent.com/866124/44666179-08fa8780-aa42-11e8-908c-be735c83b870.png)

1. I think that it would be handy to have `crop` parameter for `mask`: `raster.mask(vector, crop=True)` 2. Let's see what happening in case of using mask (first image) and crop...

It looks like this issue cannot be solved in the general case. For example, `180.0, 90.0` cannot be transformed from epsg:4326 into epsg:3857.

Are band names supposed to be list of strings? Then we should have something like this: ```python return list(map(str, self._band_names)) ``` here: https://github.com/satellogic/telluric/blob/87c203b875908a0e20c0cd06adcc1f0a034b1b1d/telluric/georaster.py#L523

I think it is because of the [GEOS 3.8.0](https://github.com/shapely/shapely-wheels/commit/31dca636ff4bab32a46eb9db925898717a7c2bf7). Faced with the same issue here.

Should we close this issue and move discussion to https://github.com/stac-extensions/video ?