Dries Vints

Results 585 comments of Dries Vints

Please add a thorough description to your PR and not just link to an issue. This will help the people reviewing your PR.

@taylorotwell going to re-open this one as we've had two reports now of graceful termination not working properly with Horizon. This PR seems to fix it for both cases. Other...

Thanks @nckrtl. @taylorotwell do you feel like we should first address the real underlying issue?

Thanks @juanparati. Will let @timacdonald review this one.

Going to close this one now as it seems stale. Feel free to resend this once you've made the necessary changes, thanks.

Hi @ragulka. Thank you for flagging this. If that's the case then yes we should fix this. I guess it's the `invoice.payment_succeeded` we need to check for this? We should...

@ragulka are you still up for sending in that PR?

Since we only had one ticket about this and there's no activity here I'm gonna close this one.

@ragulka no worries. Would still very much appreciate a PR when you can spare the time.