react-rating icon indicating copy to clipboard operation
react-rating copied to clipboard

Warning: Using UNSAFE_componentWillReceiveProps in strict mode is

Open carminoplata opened this issue 5 years ago • 11 comments

Hi everybody,

Does someone deal with this warning?

`Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://reactjs.org/link/derived-state

Please update the following components: Rating, RatingAPILayer`

carminoplata avatar Nov 11 '20 11:11 carminoplata

Yep. We need to refactor the component to get rid of this deprecated method.

I'm open to contributions.

The #134 issue was created to track the move towards a controlled component that will let us to get rid of this deprecated lifecycle method.

dreyescat avatar Nov 15 '20 18:11 dreyescat

I still have same issue. How can I resolve it?

bayramn avatar Aug 09 '21 23:08 bayramn

The issue is still present as of January 2022 :/

1OfThose avatar Jan 06 '22 14:01 1OfThose

Issue does still exist

mleister97 avatar Jan 12 '22 21:01 mleister97

Fixed it in here Selectra-Dev/react-rating#b76396d4c9c1680153817d7869a6d152d1985a90

yarn add https://github.com/Selectra-Dev/react-rating.git

mariomeraz avatar May 31 '22 19:05 mariomeraz

Are there any plans to merge those changes^ into this repo?

arcasoy avatar Jul 30 '22 02:07 arcasoy

The issue still exists July 2022

Yvad60 avatar Jul 30 '22 06:07 Yvad60

Are there any plans to merge those changes^ into this repo?

Is Fork, and no have idea...

mariomeraz avatar Aug 01 '22 16:08 mariomeraz