jack-cli

jack-cli copied to clipboard

There are some real issues with rendering on Windows. I'm not sure if it's from how I have blessed configured, or if blessed is just not fully compatible. I suspect it's the former :) Any help from Windows users would be greatly appreciated!

@drewbrokke I believe the windows incompatibility stems from relative path requirements.

ie the TS imports import { someUtil } from '../utils/someUtil'; resolves to var someUtil = require('../utils/someUtil');'

But in order to have this compatible with Windows file systems, this should resolve to var someUtil = path.resolve('../utils/someUtil');

I should probably be a little more clear in the description. It starts up and runs on Windows just fine, but there are rendering and re-drawing issues on Windows terminals (and even some non-standard terminals on the Mac like Hyper). You can see an example of this if you try to use one of the key commands that calls screen.spawn (like pressing d to do a git diff). I haven't figured out the magic config setup to resolve them yet. If it's an issue with how blessed handles things, then there's no fixing this one without finding a new library.

@jwu910 were you able to test your theory?

Hmm. I added jack as a dependency on check-it-out, and it stopped working on windows. When I saw this issue, I thought it might be as similar issue I had.

I first came across the relative path issue on earlier versions of check-it-out

@drewbrokke

were you able to test your theory?

I dont know enough typescript to get this working. Don't know any really... I was reading up over the weekend, and looking at tsconfig options. One option was to also change the compiler options so we can import w/o the use of relative paths.

oh interesting. I guess the other thing I'd add here is that jack was never meant to be added as a dependency to anything (It's strictly a consumer, not a library), so I make no guarantees about it working in that context 😉

do you have a link to the WIP code of how you were using it?

lol Maybe I'll change it back to just a regular git log....

It worked flawlessly on my linux machines with Jack... I somehow just managed to lose windows compatibility in the process.

@drewbrokke I see the issue you're talking about now. The problem I ran into earlier was not related to the jack-cli code.

Check it Out is experiencing a similar issue. on screen.spawn() and screen.exec()

I am experiencing this "ghost text" on both Linux and Windows though...