Vladislav

Results 162 comments of Vladislav

I suppose there should be advanced tests in `snapshot_test.py` for both regular save and df save, right?

It seems pretty mature now for a first phase. Note: Though I added state management to the replica, I didn't refactor any code there. This is my plan for the...

The last test is. Should I remove it and save it for later?

It seems like your linux kernel on wsl has an old io_uring version that is not supported by dragonfly. The test in the pipeline fails because you didn't add your...

```c++ TEST_F(ListFamilyTest, TwoQueueBug) { std::atomic_bool running{true}; std::atomic_int it_cnt{0}; auto popFiber = [&]() { auto id = "t-"+std::to_string(it_cnt.fetch_add(1)); while (running.load()) { Run(id, {"blpop", "a", "10"}); } }; auto pushFiber = [&]()...

The BLPopTimeout timeout test fails, it looks like the unlocking is wrong

I guess we don't need full checks in constructors ```c++ FooGL(CompileState&&) { CORRADE_INTERNAL_ASSERT_OUTPUT(checkLink()); CORRADE_INTERNAL_ASSERT_OUTPUT(cs._vert.checkCompile()); CORRADE_INTERNAL_ASSERT_OUTPUT(cs._frag.checkCompile()); ``` because in case the first check fails, the other two fill be skipped. In...

This seems to be an exciting issue to try out 🏗️ I've actually noticed the second issue straight away when passing single arguments. For example: ``` fn foo(a) {} fn...

This is a very interesting issue for scripting languages but seems to be practically unsolvable, given that even the most popular runtimes like CPython would fail on this (if you...