dragonfly

dragonfly copied to clipboard

Can you expand, please?

Feb 21 '23 20:02 romange

We now track the replica port and store it in ReplicaRoleInfo, but don't print it in the ROLE command, only the ip

Feb 21 '23 20:02 dranikpg

@ashotland Do you know why Redis print replica port in Role? When it is used? In Dragonfly we open multiple connections so we can not blindly implement this feature.

Mar 30 '23 13:03 romange

its the replica's external listening port, its sent during greet

Mar 30 '23 14:03 dranikpg

@ashotland Do you know why Redis print replica port in Role? When it is used? In Dragonfly we open multiple connections so we can not blindly implement this feature.

I don't know a reason to consume replica pot from role command maybe it is just for consistency with info replication (which we had to fix for the sentinel support). There's a lot of overlap between the two commands.

Mar 30 '23 15:03 ashotland