dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

Published 20 hours ago • verified publisher icon dragonflydb

feat(search): Multishard cutoffs

Open dranikpg opened this issue 2 years ago • 3 comments

dranikpg avatar Sep 24 '23 16:09 dranikpg

My condolences to the one reviewing it 🙂

dranikpg avatar Sep 25 '23 17:09 dranikpg

My condolences to the one reviewing it 🙂

I actually wrote Vlad - Kostas 1-1 only to not submit the comment because it would have been noise. Anyway, when you wrote this I could not resist not to write this msg :stuck_out_tongue:

I would argue mine was simpler because it was mostly boilerplate (I haven't looked yours TBH so it could be the same case) so it's not really 1-1 and probably you are getting the :crown: :man_cook:

kostasrim avatar Sep 26 '23 07:09 kostasrim

@kostasrim @chakaz

Please take a quick look at this. There is still some polishment left but the general "structure" is ready.

I'd wish for this to be merged before we announce search because it's important for fast multishard queries

PS: Yes there is lots of code and it's complicated 🙂 I'd start looking from MultiShardSearch::Run because it's the main entry point w everything else being tailored to fit it's needs

dranikpg avatar Oct 29 '23 15:10 dranikpg