dracut icon indicating copy to clipboard operation
dracut copied to clipboard

fix(resume): fix including module in hostonly mode

Open Nowa-Ammerlaan opened this issue 2 years ago • 3 comments

The grep introduced in commit e3a7112bef794e2f2dd741ec2c74fa9cb9117651 does not work as intended. The resume module is always excluded in hostonly mode.

Made this a bit more explicit with if/else so it is more clear what is going on. The in-line ||/&& makes the line really long and makes it more difficult to understand what is going on.

Bug: https://github.com/dracutdevs/dracut/issues/924

Checklist

  • [x] I have tested it locally
  • [ ] I have reviewed and updated any documentation if relevant
  • [ ] I am providing new code and test(s) for it

Nowa-Ammerlaan avatar Aug 20 '23 09:08 Nowa-Ammerlaan

Closing in favour of https://github.com/dracutdevs/dracut/pull/2374

Nowa-Ammerlaan avatar Sep 11 '23 06:09 Nowa-Ammerlaan

Gentle ping, I think this fixes quite a serious issue. We have this patch backported in our latest snapshot version in Gentoo: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=803a7e0b95164ddb661dee1448a4b19eceb09cc2

Nowa-Ammerlaan avatar Nov 13 '23 15:11 Nowa-Ammerlaan

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

stale[bot] avatar Apr 22 '24 09:04 stale[bot]

Resolved by: https://github.com/dracut-ng/dracut-ng/commit/d2ff89e24479f1b8c2a21613632a4beb58c2a182

Closing.

Nowa-Ammerlaan avatar May 08 '24 09:05 Nowa-Ammerlaan