dracut

dracut copied to clipboard

It seems dhclient's --timeout option is not upstream [1], apparently it's RH-only [2]..., so a pre-check is needed before using it.

[1] https://github.com/isc-projects/dhcp [2] https://github.com/landgraf/dhcp-fedora/commit/d171ac96

Some tests already take this into account:

https://github.com/dracutdevs/dracut/blob/fe8fa2b0cadbb33e27c8dd8b5851548dcd65835c/test/TEST-20-NFS/test.sh#L73-L75

https://github.com/dracutdevs/dracut/blob/fe8fa2b0cadbb33e27c8dd8b5851548dcd65835c/test/TEST-50-MULTINIC/test.sh#L73-L75

Checklist

• [X] I have tested it locally
• [ ] I have reviewed and updated any documentation if relevant
• [ ] I am providing new code and test(s) for it

This is a nack it's better that we simply stop supporting legacy networking altogether, it's on it's way out in Fedora ( which probably means it's already not supported in Arch ) and if the existing behaviour was somehow reliant on a patch from RH existing in downstream distro's it propably means it got rejected upstream and it makes no sense to add checks to modules to see if an option added by some downstream distro patch exist or not.

That's ok, but before dropping the network-legacy module, I'd first make sure that any of the other network modules support all of the command line parameters that the legacy module supports (which is something I'm currently reviewing).

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

That's ok, but before dropping the network-legacy module, I'd first make sure that any of the other network modules support all of the command line parameters that the legacy module supports (which is something I'm currently reviewing).

@aafeijoo-suse what was the outcome of that reviewing?

The initial review is here: #1876 On paper the features that NM lacks are minor. We cannot test every possible setup, but I think @tblume is having some issues with the iSCSI tests. On the other hand, I know you're aware that the network-legacy module is the only option for non-systemd distros right now (#1756). SUSE also needs it (and we'll have to maintain it for years). That's all I can say, I see your point and it's not my decision to drop it upstream :)

@LaszloGombos ping for review.