dracut icon indicating copy to clipboard operation
dracut copied to clipboard

Published 20 hours ago • verified publisher icon dracutdevs

feat(dracut-install): Add an optional file with hashes of included files

Open jamacku opened this issue 3 years ago • 8 comments

Changes

This patch is adding hashing functionality into dracut-install. From every source is generated a hash which is stored into a file together with the destination path. Function uses MD5 algorithm from openssl library.

eg.: f222f1bfcee4a4d02abfcaf24de19ab0 /root/tmp/dest/usr/bin/test

This can be used to track changes in source.

Checklist

  • [x] I have tested it locally
  • [x] I have reviewed and updated any documentation if relevant
  • [ ] I am providing new code and test(s) for it

jamacku avatar May 27 '22 13:05 jamacku

@jamacku can you update your PR to include in the docker images the missing libraries and header files that are needed to be linked to openssl as in openssl-devel for Fedora based platform, libssl-dev for Debian based platforms etc.

johannbg avatar May 30 '22 18:05 johannbg

@johannbg I updated Dockerfiles.

jamacku avatar May 31 '22 06:05 jamacku

@jamacku the test are still spectacularly failing so you need to have a better look at that

johannbg avatar May 31 '22 07:05 johannbg

@jamacku the test are still spectacularly failing so you need to have a better look at that

Changes of Dockerfiles in this PR has no impact on integration tests, since containers are updated only on push events.

https://github.com/dracutdevs/dracut/blob/master/.github/workflows/container.yml#L53

jamacku avatar Jun 03 '22 07:06 jamacku

Changes of Dockerfiles in this PR has no impact on integration tests, since containers are updated only on push events.

I think this is one of the cases where having an option for manual trigger could be useful for the project - as proposed earlier in https://github.com/dracutdevs/dracut/pull/1816

LaszloGombos avatar Jun 05 '22 14:06 LaszloGombos

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

stale[bot] avatar Jul 06 '22 23:07 stale[bot]

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

stale[bot] avatar Aug 31 '22 11:08 stale[bot]

Thanks for the review, @marcosfrm. Could you please have another look?

jamacku avatar Aug 31 '22 12:08 jamacku

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

stale[bot] avatar Sep 30 '22 23:09 stale[bot]