dracut

dracut copied to clipboard

Changes

See individual commit messages; draft because on top of #1794

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

bad bot

rebased

Please move the last three commits to a different PR to facilitate review.

fix: return valid path on abs_rel error feat: canonicalise parent of abs_rel() from, too perf: don't allocate abs_rel() target parent realpath

#1851

Rebased with #1845 and #1851 trimmed off

all applied

Take a look at

https://github.com/marcosfrm/dracut/commit/67e26afda46c69c834185943b0fac1a5b980219b

it allows use lib until library_install() end. Feel free to add it to this PR if I not missed anything.

Or I can open a new PR for the dirname() stuff.

LGTM

Edit: need to fix the commit messages...

Ping?

Take a look at

marcosfrm@67e26af

it allows use lib until library_install() end. Feel free to add it to this PR if I not missed anything.

Actually the last strdup() is required because POSIX basename(), as it expects char *path and switching to the GNU version possibly can break other libcs -- musl only implements the POSIX version if i remember correctly.

Month bump

Commit messages still need changes.

Appended (dracut-install) to all that touch the .c

For a clean git history, needs rebase after 7f2b09339c063279f736f6d4f079f6dd7ed10577

LGTM

Can this go in to get more testing?

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

bad bot

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

ping

pong. looks fine on my end?

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

so true, bestie

Personally, I would prefer having https://github.com/dracutdevs/dracut/pull/1987 around to help out for these reviews. Not sure if someone there is a way to do a run just for this PR.

unresolved conversation and un-requested re-reviews ( @marcosfrm acked in comment section not in the review process ) has the tendency to get pr ignored from those of us that are quite busy anyways let's not merge this until in 059 milestone