dracut

dracut copied to clipboard

… arping to the default gateway

This pull request changes dracut-network. Fixes two bugs which cause minutes long boot times caused by unneeded "arping -q -f -w 60" to the default gateway (when unresponsive) even if the NFS server is on the local network. This was evident in logs like "dracut-initqueue[x]: Resolving x.x.x.34 via ARP on br0 failed".

Changes

modules.d/40network/net-lib.sh

Checklist

• [x ] I have tested it locally
• [x] I have reviewed and updated any documentation if relevant
• [ x] I am providing new code and test(s) for it

Fixes #

• get_netroot_ip() had first two arguments interchanged in 'splitsep ":" "$1" prefix server rest'
• ip_is_local() was returning negated values from 'strstr "$(ip route get "$@" 2> /dev/null)" " via "'

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

[modules.d/40network/net-lib.sh] still has two obvious bugs.

Please fix the CI issue: Error: commit_message:1:1: error: use of type tag that's neither 'feat', 'fix' nor whitelisted (build, chore, ci, docs, perf, refactor, revert, style, test, improvement)

Otherwise LGTM.

@tuppero Are you in a position to edit the commit message title (not the github title).

The following first line (or something similar) would make the commit message checker happy

fix(network): avoid arping the gateway for a faster boot

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

not stale

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@tuppero does not seem to be a very active contributor on Github.

However he granted us permissions for "Allow edits from maintainers.”, so I used the following guide to fix up the commit message - https://tighten.com/blog/adding-commits-to-a-pull-request/ .

For a project like dracut I suspect we will see more of these "drive-by" contributions as the project grows and if the change looks good otherwise, we should make an effort to integrate it.