vim icon indicating copy to clipboard operation
vim copied to clipboard

Make dracula work with diffchar

Open ferdinandyb opened this issue 3 years ago • 2 comments

Screenshots and background in this issue: https://github.com/rickhowe/diffchar.vim/issues/25

Code is by @rickhowe, not me.

Thanks for considering!

ferdinandyb avatar Jan 18 '22 06:01 ferdinandyb

I think this is really a temporary workaround, right? The real issue is that the other plugin didn't handle linked highlight groups correctly.

IIRC from threads on the mailing list, some folks are working on improving the vimscript API for handling highlights. Perhaps the plugin author needs to check that work and fix the plugin?

OTOH, I'm not really opposed to un-linking. Just want to make sure we're not taking on extra work for an out-of-band or out-of-scope issue.

benknoble avatar Jan 18 '22 21:01 benknoble

Is this still something that we need? Did the upstream issue get resolved, and either way is this something we should consider merging?

benknoble avatar Aug 10 '22 15:08 benknoble

sorry for the late answer, tbh, I'm not sure what the situation is, I'll try to get around to checking this this week

ferdinandyb avatar Aug 15 '22 21:08 ferdinandyb

The diffchar plugin sorted this on their side, everything works as expected from dracula and diffchar master branches so this PR is now obsolete. Thanks!

ferdinandyb avatar Aug 25 '22 07:08 ferdinandyb